Updated SIA up-casing behavior

astropy / pyvo

An Astropy affiliated package providing access to remote data and services of the Virtual Observatory (VO) using Python.

https://pyvo.readthedocs.io/en/latest

BSD 3-Clause "New" or "Revised" License

74 stars 50 forks source link

Updated SIA up-casing behavior #545

Closed d-giles closed 1 month ago

d-giles commented 2 months ago

Modified the behavior of the SIA service where it would upcase all format keywords. Modified to upcase keywords "ALL", "METADATA", and "GRAPHIC", otherwise the parameter is passed unchanged. The format "GRAPHIC-xyz" will capitalize "GRAPHIC" and leave the rest unchanged.

Tests have been added to check that the formats are cased as expected. Variable names have been updated to be more descriptive.

Edit: changed description of PR to reflect updates.

bsipocz commented 2 months ago

We don't need to worry about the changelog failure above, I can move the entry to the bugfix section when/if I'm cutting a bugfix release (not yet sure we will have that or go ahead with the feature release sometimes soon).

bsipocz commented 2 months ago

@pllim - please add @d-giles to the org, so I don't need to approve CI after each commit

pllim commented 2 months ago

Re: https://github.com/astropy/pyvo/pull/545#issuecomment-2101393540

Added. Hope it helps!

bsipocz commented 1 month ago

Given the imminent 1.5.2 release, I go ahead and rebase this to fix the conflict, and rerun with a fixed CI.