astropy / pyvo

An Astropy affiliated package providing access to remote data and services of the Virtual Observatory (VO) using Python.
https://pyvo.readthedocs.io/en/latest
BSD 3-Clause "New" or "Revised" License
74 stars 50 forks source link

Update of the dictionaries that are used to build the MIVOT_INSTANCE #551

Closed lmichel closed 1 week ago

lmichel commented 1 month ago

The model references in the dictionaries that are used to build MivotInstance objects are more consistent:

    {
        "dmtype": "mango:EpochPosition",
        "longitude": {"value": 359.94372764, "unit": "deg"},
        "latitude": {"value": -0.28005255, "unit": "deg"},
        "pmLongitude": {"value": -5.14, "unit": "mas/yr"},
        "pmLatitude": {"value": -25.43, "unit": "mas/yr"},
        "epoch": {"value": 1991.25, "unit": "year"},
        "coordSys": {
            "dmtype": "coords:SpaceSys",
            "dmid": "ICRS",
            "dmrole": "coords:Coordinate.coordSys",
            "spaceRefFrame": {"value": "ICRS"},
        },
    }

This makes the understanding of these dictionaries and the use of the MivotInstance objects quite easier and more intuitive.

bsipocz commented 1 week ago

I'll rebase this to fix the changelog conflict, and will go ahead and merge.

bsipocz commented 1 week ago

Thank you @lmichel!