astropy / pyvo

An Astropy affiliated package providing access to remote data and services of the Virtual Observatory (VO) using Python.
https://pyvo.readthedocs.io/en/latest
BSD 3-Clause "New" or "Revised" License
74 stars 50 forks source link

BUG: fix keyword arguments #555

Closed bsipocz closed 2 weeks ago

bsipocz commented 3 weeks ago

This is a follow-up to #507, apparently this part of the code is not covered by tests, but it is used in astroquery's remote test suite, thus I caught it before we landed a release.

bsipocz commented 3 weeks ago

cc @msdemlei - while I was fixing keyword argument stuff, I added the modifications you asked for SIAv1 in https://github.com/astropy/pyvo/issues/512#issuecomment-2163143762

bsipocz commented 3 weeks ago

And now this also includes a skip for the flaky doctest that is unrelated and what we also see in the other PRs.

bsipocz commented 2 weeks ago

Thanks. Let me remove the last commit before merging, as it has been fixed separately and better in a recent PR.