search

astropy / pyvo

An Astropy affiliated package providing access to remote data and services of the Virtual Observatory (VO) using Python.
https://pyvo.readthedocs.io/en/latest
BSD 3-Clause "New" or "Revised" License
74 stars 50 forks source link

Stale alt_identifier join damages RegistryResource-s with multiple alternative identifiers #560

Closed msdemlei closed 2 weeks ago

msdemlei commented 2 weeks ago

During our recent consideration of what to do with alternative identifiers in our registry API (PR #492) and our decision to to pull them every time (PR #523), we forgot to remove alt_indentifiers from the template query.

That, in turn, is a problem when a resource has multiple alt_identifiers; for instance,

from pyvo import registry

print(
    registry.search(
        registry.Ivoid("ivo://cds.vizier/iii/175")
    )[0].describe())

will show many identical interfaces; this is because there are four alternate identifiers on this record.

The fix is simple: drop the alt_identifiers joins.