No longer joining alt_identifier into our RegTAP template query.

astropy / pyvo

An Astropy affiliated package providing access to remote data and services of the Virtual Observatory (VO) using Python.

https://pyvo.readthedocs.io/en/latest

BSD 3-Clause "New" or "Revised" License

74 stars 50 forks source link

No longer joining alt_identifier into our RegTAP template query. #561

Closed msdemlei closed 2 weeks ago

msdemlei commented 2 weeks ago

This fixes #560.

ManonMarchand commented 2 weeks ago

Ah yes, we missed it!

msdemlei commented 2 weeks ago

On Wed, Jun 26, 2024 at 12:25:17AM -0700, Manon Marchand wrote:

@ManonMarchand approved this pull request.

Thanks! I'd argue this is such a minor bugfix that a changelog entry is not necessary; and test failures (I'll fix the datalink-related ones in #559) are unrelated to this change, so I think this is ready to go.

bsipocz commented 2 weeks ago

Thanks! Also, @ManonMarchand, please feel free to merge PRs once you approve them, unless there are some remaining discussion/todo items.