search

astropy / pyvo

An Astropy affiliated package providing access to remote data and services of the Virtual Observatory (VO) using Python.
https://pyvo.readthedocs.io/en/latest
BSD 3-Clause "New" or "Revised" License
74 stars 50 forks source link

DOC: fix doctest output #564

Closed bsipocz closed 2 weeks ago

bsipocz commented 2 weeks ago

Quick PR to fix the CI. If this same example break again, then we should switch using +IGNORE_OUTPUT, but for now fixing it seems reasonable.

bsipocz commented 2 weeks ago

I don't think we should run external docs linkcheck for each commit, but move that job to be run from cron only. What do you all think?

msdemlei commented 2 weeks ago

On Wed, Jun 26, 2024 at 09:32:54AM -0700, Brigitta Sipőcz wrote:

Quick PR to fix the CI. If this same example break again, then we should switch using +IGNORE_OUTPUT, but for now fixing it seems reasonable. You can view, comment on, or merge this pull request online at:

https://github.com/astropy/pyvo/pull/564

Hm... what TOP 10 * from ivoa.obscore returns (and that's what determines this output) is conceptually random. It's hence a micracle this occasonally works at all :-)

I'd prefer it if we made that query result predictable while running reasonably fast. This would be easy if we didn't query such a large and (internally) complex table as ivoa.obscore on that box. But I think it's actually a good idea to use obscore as an example here, and I wouldn't want to re-structure the whole flow below the query, either.

So, I have made PR #565 that I'd hope will stabilise the whole thing. That would be an alternative to this PR. Can you have a look?