Closed astrofrog closed 2 months ago
Attention: Patch coverage is 83.33333%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 93.63%. Comparing base (
2dedbc5
) to head (b42f7c6
). Report is 17 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
reproject/common.py | 83.33% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Should the deep copy only be done for the multi-threading case, or is the copy so fast + low-memory that it does not matter
@manodeep - the deep copy only takes ~10µs for a typical WCS, so it will be buried in the noise
The fix here is a workaround but it is acceptable enough to just go ahead and merge, as even though it does not fix astropy upstream, it should basically make multi-threading usable here.
Let's get this fix in 🚀
To run just the relevant test:
This currently shows three test failures:
To run just one of the parameter combinations of the test, one can do e.g.: