search

astropy / saba

A Package which allows astropy to interface with sherpa
GNU General Public License v3.0
8 stars 9 forks source link

Remove ipython doc dependency #19

Closed mirca closed 7 years ago

mirca commented 7 years ago

Since #14 got merged, it looks like docs do not dependent on ipython anymore. So, hopefully closes #16.

cc @nocturnalastro @bsipocz

bsipocz commented 7 years ago

@mirca - Looks good, though I wonder why you've skipped the doctest for some of the snippet lines?

mirca commented 7 years ago

@bsipocz Those lines which are skipped are tested under the plot directives. I've skipped some so that I don't need to repeat the whole code under plot. :)

bsipocz commented 7 years ago

I mentioned it only as leaving them untested gives a chance to diverge in future. That said I have to admit that there are packages without running doctest on the narrative docs that I yet have to fix, figure out how to do better.

mirca commented 7 years ago

@nocturnalastro are you happy with these changes? ;)

nocturnalastro commented 7 years ago

@mirca, sorry I hadn't looked before. Looks fine, as @bsipocz said we'll have to keep an eye on changes made to the docs to make sure that the plot and snippets are the same so we don't have to worry about testing the snippets.

mirca commented 7 years ago

@nocturnalastro sure!