Closed pllim closed 10 months ago
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
aa4ceab
) 78.83% compared to head (bbf377d
) 81.32%.
Files | Patch % | Lines |
---|---|---|
specreduce/fluxcal.py | 50.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Close/reopen to see if RTD pops up.
Sorry about the conflict with #182 . I don't watch this repo so I was not aware of it. I replied in https://github.com/astropy/specreduce/pull/202#discussion_r1418278247 (I think it is a little too soon but I am also not a specreduce maintainer).
Whether you want to merge this first, or cherry-pick your changes to this PR and take this over, I will leave to you.
no worries on the conflicts. i would say let's merge this ASAP and i'll do what i need to do to clean up #182. it's the code changes that i've made in #182 that require 3.10+, iirc. if we want to stick with bumping the requirement there vs here, i'm fine with that. interested in @kecnry's take.
I don't have any strong opinions on the order of operations - good to merge on my end! Thanks for all the improvements @pllim !
Then, feel free to merge! I am tempted to merge myself but I shouldn't. Thanks!
I stared into the code and I couldn't unsee things, so here it is.
--remote-data
flag in any of your CI job.~Unable to handle this one until I get access:~
203
After merge, can add new job names to branch protection.