search

astropy / specreduce

Tools for the reduction of spectroscopic observations from Optical and NIR instruments
https://specreduce.readthedocs.io
62 stars 38 forks source link

Fix for PypeIt calibration line loading #231

Closed hpparvi closed 1 week ago

hpparvi commented 1 week ago

This PR fixes Issue #227 by converting the linelist table in specreduce.calibration_data.load_pypeit_calibration_lines from a Table to a QTable before calling specutils.utils.wcs_utils.vac_to_air. The vac_to_air function requires wavelengths to be given as Quantity objects, but the line list was a Table instead of a QTable.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.36%. Comparing base (2cc466d) to head (d88f5c1). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #231 +/- ## ========================================== - Coverage 83.37% 83.36% -0.02% ========================================== Files 13 13 Lines 1137 1136 -1 ========================================== - Hits 948 947 -1 Misses 189 189 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.