Closed rosteen closed 7 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
425eab3
) 71.07% compared to head (4019868
) 70.93%.:exclamation: Current head 4019868 differs from pull request most recent head 1e00460. Consider uploading reports for the commit 1e00460 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Looks like your devdeps job pulls in numpy 2.0.dev but I also see warnings, so please inspect the log carefully.
https://github.com/astropy/specutils/actions/runs/7832040522/job/21369775774?pr=1123
Looks like your devdeps job pulls in numpy 2.0.dev but I also see warnings, so please inspect the log carefully.
https://github.com/astropy/specutils/actions/runs/7832040522/job/21369775774?pr=1123
As far as I could tell the only warning was from an upstream package, nothing to do with this. This PR actually fixes some numpy
-related errors, although I think that's due to a pre-2.0 update. I got a thumbs-up for this offline so I'll probably merge after tests pass rather than wait for more input (unless you want to give feedback on the actual changes, Pey Lian).
I think the actual diff looks reasonable. I think the new str and repr are nicer. Thanks!
Test failure was a timeout, merging.
Fixes #1073, as well as improving the readability/concision of the
__repr__
format (especially for things like large cubes). Still tweaking this but it's close, tests will need updating as well.