search

astropy / specutils

An Astropy coordinated package for astronomical spectroscopy. Maintainers: @nmearl @rosteen @keflavich @eteq
http://specutils.readthedocs.io/en/latest/
161 stars 124 forks source link

Change new_flux_unit to with_flux unit #1124

Closed rosteen closed 4 months ago

rosteen commented 4 months ago

I was cleaning up some old issues and noticed #890, this addresses that by making the function analogous to the updated with_spectral_axis_unit and correcting the docstring. Would have been nice to get this into 1.13.0 but thems the breaks.

Closes #890.

codecov[bot] commented 4 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2fe4fa2) 72.21% compared to head (1724ab4) 72.21%.

Files Patch % Lines
specutils/spectra/spectrum_mixin.py 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1124 +/- ## ========================================== - Coverage 72.21% 72.21% -0.01% ========================================== Files 62 62 Lines 4427 4430 +3 ========================================== + Hits 3197 3199 +2 - Misses 1230 1231 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.