Closed rosteen closed 3 months ago
Attention: Patch coverage is 75.80645%
with 30 lines
in your changes are missing coverage. Please review.
Project coverage is 72.72%. Comparing base (
4041081
) to head (40ac61b
). Report is 37 commits behind head on v2.0-dev.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Looks like the test failure is unrelated, I wonder if that MANGA file was removed or changed url or something...
This is probably the most important part if anyone reviews:
@deprecated(since="2.0", alternative="Spectrum")
class Spectrum1D(Spectrum):
def __init__(self, *args, **kwargs):
super().__init__(*args, **kwargs)
Does what it says on the tin - based on the result of https://github.com/astropy/specutils/discussions/1087.
Spectrum1D
will raise a deprecation warning when initialized for some deprecation period.