search

astropy / specutils

An Astropy coordinated package for astronomical spectroscopy. Maintainers: @nmearl @rosteen @keflavich @eteq
http://specutils.readthedocs.io/en/latest/
161 stars 124 forks source link

TST: Coverage upload failed despite green CI #1137

Closed pllim closed 1 month ago

pllim commented 1 month ago

Example log: https://github.com/astropy/specutils/actions/runs/9006471036/job/24744084651

error - 2024-05-08 18:14:08,329 -- Upload failed: {"detail":"You do not have permission to perform this action."}

Proposed solution:

  1. Investigate why the token is not working. This needs admin access to do.
  2. Since you are not using OpenAstronomy template, consider something like https://github.com/spacetelescope/jdaviz/pull/2869 to make upload failures obvious.
rosteen commented 1 month ago

Fixed, see https://github.com/astropy/specutils/actions/runs/9006471036/job/24953326448. I think I had accidentally added my fork's token to the secret rather than that of the base repository. I also opened #1138 to separate out the coverage upload as you suggested.

pllim commented 1 month ago

Thanks!