search

astropy / specutils

An Astropy coordinated package for astronomical spectroscopy. Maintainers: @nmearl @rosteen @keflavich @eteq
http://specutils.readthedocs.io/en/latest/
161 stars 124 forks source link

Separate out the codecov upload to a separate job in CI #1138

Closed rosteen closed 1 month ago

rosteen commented 1 month ago

This will let us see a test failure if the coverage upload fails. Thanks to @pllim for the example.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.82%. Comparing base (1a1164f) to head (50e70cf).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1138 +/- ## ======================================= Coverage 86.82% 86.82% ======================================= Files 63 63 Lines 4525 4525 ======================================= Hits 3929 3929 Misses 596 596 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rosteen commented 1 month ago

It works, merging.

pllim commented 1 month ago

Over at https://github.com/OpenAstronomy/github-actions-workflows/pull/199 , I found a bug in this setup where if we have two jobs that generate coverage, one will clobber the other. Since we only have one coverage job here, it doesn't matter. But if the situation change in the future, we can either switch to OpenAstronomy or I apply the same patch here. FYI.