Spectrum1D.from_fits and Spectrum1D.from_ascii should not exist

astropy / specutils

An Astropy coordinated package for astronomical spectroscopy. Maintainers: @rosteen @keflavich @eteq

http://specutils.readthedocs.io/en/latest/

169 stars 127 forks source link

Spectrum1D.from_fits and Spectrum1D.from_ascii should not exist #117

Closed astrofrog closed 7 years ago

astrofrog commented 9 years ago

Spectrum1D.from_fits and Spectrum1D.from_ascii should not exist - instead, specutils should be defining readers/writers via the unified I/O interface and registering them for the Spectrum1D class.

Spectrum1D should inherit from the NDIOMixin class to enable this.

@wkerzendorf - was there a reason for not doing this that I am missing?

wkerzendorf commented 9 years ago

@astrofrog - yep there was a reason - when this was built NDIOMixin did not exist :wink: . Thanks for the heads-up I actually didn't know about this.

astrofrog commented 9 years ago

@wkerzendorf - np :) let me know if you need any help in defining the readers/writers!

wkerzendorf commented 9 years ago

@astrofrog yes definitely. Currently it seems also that modeling has changed again and it seems specutils has issues again. I'm also travelling, which doesn't help the issue :frowning: