Closed rosteen closed 1 month ago
Don't want to use towncrier while you are at it? 😉
Looks like it works because it is failing because you didn't apply the label. ;D
You might have to clean up the change log or something? See warnings in https://github.com/astropy/specutils/actions/runs/11169575830/job/31050585269?pr=1177
Also, from now on, you would need to also make sure all PRs are milestoned properly to match the change log section.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 86.86%. Comparing base (
07c1883
) to head (4705ece
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Oh yeah, maybe. @bsipocz added that one, I think.
Everything in the changelog is passing now except for this PR missing an entry.
I also have a milestone check if you change your mind about milestones. 😆
Just gonna leave this here. 😝
https://github.com/astropy/astropy/blob/main/.github/workflows/check_milestone.yml
Thanks for the help/eyes on this!
Oh yeah, maybe. @bsipocz added that one, I think.
You got me in a cold sweat for a moment thinking that I was going senile, but then I checked and it was William adding that functionality :)
Oh ooops! Sorry. I should have checked. I am the one getting senile!
Closes #1165 . Thanks @pllim for the links 🙂