astropy / specutils

An Astropy coordinated package for astronomical spectroscopy. Maintainers: @rosteen @keflavich @eteq
http://specutils.readthedocs.io/en/latest/
170 stars 127 forks source link

Add changelog check to CI #1177

Closed rosteen closed 1 month ago

rosteen commented 1 month ago

Closes #1165 . Thanks @pllim for the links 🙂

pllim commented 1 month ago

Don't want to use towncrier while you are at it? 😉

Looks like it works because it is failing because you didn't apply the label. ;D

pllim commented 1 month ago

You might have to clean up the change log or something? See warnings in https://github.com/astropy/specutils/actions/runs/11169575830/job/31050585269?pr=1177

Also, from now on, you would need to also make sure all PRs are milestoned properly to match the change log section.

rosteen commented 1 month ago

Also, from now on, you would need to also make sure all PRs are milestoned properly to match the change log section.

Doesn't CHECK_MILESTONE: false avoid that check?

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.86%. Comparing base (07c1883) to head (4705ece).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1177 +/- ## ======================================= Coverage 86.86% 86.86% ======================================= Files 63 63 Lines 4553 4553 ======================================= Hits 3955 3955 Misses 598 598 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pllim commented 1 month ago

Oh yeah, maybe. @bsipocz added that one, I think.

rosteen commented 1 month ago

Everything in the changelog is passing now except for this PR missing an entry.

pllim commented 1 month ago

I also have a milestone check if you change your mind about milestones. 😆

pllim commented 1 month ago

Just gonna leave this here. 😝

https://github.com/astropy/astropy/blob/main/.github/workflows/check_milestone.yml

rosteen commented 1 month ago

Thanks for the help/eyes on this!

bsipocz commented 1 month ago

Oh yeah, maybe. @bsipocz added that one, I think.

You got me in a cold sweat for a moment thinking that I was going senile, but then I checked and it was William adding that functionality :)

pllim commented 1 month ago

Oh ooops! Sorry. I should have checked. I am the one getting senile!