astropy / specutils

An Astropy coordinated package for astronomical spectroscopy. Maintainers: @rosteen @keflavich @eteq
http://specutils.readthedocs.io/en/latest/
169 stars 127 forks source link

Read in IRAF FITS format (including multispec) #229

Open andycasey opened 6 years ago

andycasey commented 6 years ago

👋

I have some code (that @alexji and I maintain) that reads in IRAF FITS format of various types (chebyshev, legendre, polynomial, etc) that I'd be happy to update and create a pull request to bring it into the astropy ecosystem. It handles various dispersion mappings and multispec formats.

Would this be useful? If so, am I right in assuming that I should introduce it as an adapter in the specutils/wcs?

nmearl commented 6 years ago

Hey @andycasey! We do have an implementation for reading IRAF FITS format in the previous specutils iteration, although it has not been brought over to the new specutils yet.

If you're interested, I would encourage you to see if merging the two implementations to perhaps improve upon what we both have is possible.

You would not need to create a new wcs adapter, as it's still a FITS file, and should follow the FITS wcs paradigm.

crawfordsm commented 6 years ago

I think @simontorres was also working on this in #192

simontorres commented 6 years ago

Yes, what I have done is mostly for reading non-linear wavelength solutions.

travegre commented 3 years ago

Hi all,

I was wondering if there is already a way (an implementation) to read multispec IRAF spectra with the new astropy/specutils versions?

simontorres commented 3 years ago

I implemented some of the features some time ago but I'm not sure how it's working now or whether it survived all the recent changes in the package or maybe someone improved it.

Either way I must say it's tricky, at least that was my experience.