astropy / sphinx-automodapi

Sphinx extension for generating API documentation
https://sphinx-automodapi.readthedocs.io
BSD 3-Clause "New" or "Revised" License
63 stars 45 forks source link

Fix allowed names #111

Closed mhvk closed 4 years ago

mhvk commented 4 years ago

The present implementation of :allowed-package-names: was rather broken, as I found out when trying to use it on a module that is filled using entry points. This makes at least my case work.

cc @astrofrog - I note that there are quite a few PRs pending. Maybe good to try to get help in maintaining this??? (I may be able to do some).

codecov[bot] commented 4 years ago

Codecov Report

Merging #111 into master will increase coverage by 0.86%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
+ Coverage   87.19%   88.05%   +0.86%     
==========================================
  Files           5        5              
  Lines         695      695              
==========================================
+ Hits          606      612       +6     
+ Misses         89       83       -6     
Impacted Files Coverage Δ
sphinx_automodapi/automodapi.py 93.67% <100.00%> (+2.53%) :arrow_up:
sphinx_automodapi/utils.py 88.59% <100.00%> (ø)
sphinx_automodapi/automodsumm.py 86.36% <0.00%> (+0.60%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4c8e33c...4b45b29. Read the comment docs.

mhvk commented 4 years ago

ping

mhvk commented 4 years ago

@astrofrog - thanks! Just to be absolutely sure, I think the thing that indeed needs doing is to try to organize the roles - you should have help in maintaining these! (And more generally, we need a few more people willing to help consistently - I'd love to somewhat reduce my level myself.)