astrorama / SourceXtractorPlusPlus

SourceXtractor++, the next generation SExtractor
https://astrorama.github.io/SourceXtractorPlusPlus/
GNU Lesser General Public License v3.0
72 stars 9 forks source link

Option "--property-column-mapping-all" does not work anymore #447

Closed mkuemmel closed 2 years ago

mkuemmel commented 2 years ago

The command: E-Run SourceXtractorPlusPlus 0.16 sourcextractor++ --property-column-mapping-all

ends with: MLMeasurement: 2022-02-10T14:22:52CET SourceXtractor FATAL : map::at 2022-02-10T14:22:52CET Python::Interpreter INFO : Python GIL acquired 0 times Tried to debug it, but failed.

marcschefer commented 2 years ago

It's the MLMeasurement plugin which was recently renamed from Onnx, it looks that I broke that feature by renaming the visible name but not the internal type.

marcschefer commented 2 years ago

Actually that was already broken in 0.15 so it's not related to renaming, we just never noticed.

It's the only plugin that has an output but no default column when not configured.

mkuemmel commented 2 years ago

Interestingly the Jenkins versions 0.16 and 0.17 don't show this error. The property "MLMeasurement:" does not exist there:

KronRadius: - kron_radius : Kron radius pixel - kron_flag : Flags for the Kron radius MoffatModelFitting: - smf_x : X-position of the Moffat fit pixel - smf_y : Y-position of the Moffat fit pixel - smf_iter : Number of iterations in the Moffat fitting

mkuemmel commented 2 years ago

Just realized that in Jenkins or in eden-3.0 ONNX does not exist hence the property is not compiled in at all.