"NOPSF" in the configuration files results in no PSF in the fitting

astrorama / SourceXtractorPlusPlus

SourceXtractor++, the next generation SExtractor

https://astrorama.github.io/SourceXtractorPlusPlus/

GNU Lesser General Public License v3.0

72 stars 9 forks source link

"NOPSF" in the configuration files results in no PSF in the fitting #458

Closed mkuemmel closed 2 years ago

mkuemmel commented 2 years ago

Happy to discuss tomorrow.

marcschefer commented 2 years ago

@mkuemmel apparently I can't add you as reviewer since you opened pull request originally. But please have a look at the changes and test if you want to.

mkuemmel commented 2 years ago

I had a look and did some tests. Here a comparison for four extension of a defocussed VIS image. old is the delta-function PSF and new what's in now. I think the big scatter in "ext" is from deblended and fake sources. Still the other extensions the new FWHM values for the Gauss fit are more compact. fwhm_comparison

marcschefer commented 2 years ago

Is it ok to merge?

mkuemmel commented 2 years ago

I am kind of puzzled about the big differences with respect to the first implementation. On the other hand the new results are more compact, so we should go for it and do some tests when there is time....

Formally Alejandro needs to give his approval.