astrorama / SourceXtractorPlusPlus

SourceXtractor++, the next generation SExtractor
https://astrorama.github.io/SourceXtractorPlusPlus/
GNU Lesser General Public License v3.0
72 stars 9 forks source link

how to get X,Y PEAK values? #464

Closed plaszczy closed 2 years ago

plaszczy commented 2 years ago

hi, there used to be the XPEAK,YPEAK values in SE2. However I can't find it in ShapeParameters. Is is available somewhere?

mkuemmel commented 2 years ago

The property is called PeakValue in SE++. Note that: sourcextractor++ --list-output-properties lists all available properties. This one is quite explicit, no?

plaszczy commented 2 years ago

yes I tried it. but it gives only the Peak value not the position of the peak. Can we deduce it from other properties?

mkuemmel commented 2 years ago

What you can do is the following:

Not that sure whether this counts as "deduce from other properties", though. If you really think it make sense to have the x.y values make a request and we will discuss it. The implementation is not that difficult for the detection image.

plaszczy commented 2 years ago

I think it used to be there in SE2, could be added to the PeakValue property. I'll make a request, thanks.

plaszczy commented 2 years ago

not sure how to make a request..on the PR page I can't create one (it goes to some code comparison page...)

mkuemmel commented 2 years ago

Well, just open a new ticket on github.

But in the end everyone got this conversation, so the situation is clear.

plaszczy commented 2 years ago

OK thank you

plaszczy commented 2 years ago

If I understand correctly, shoudl'nt have closed this thread,

mkuemmel commented 2 years ago

@plaszczy v0.17 is out since two weeks. Could you confirm that this measurement is there? Can we close the issue?