search

astrorama / SourceXtractorPlusPlus

SourceXtractor++, the next generation SExtractor
https://astrorama.github.io/SourceXtractorPlusPlus/
GNU Lesser General Public License v3.0
72 stars 9 forks source link

Change assoc mode column numbers to start at 1 #484

Closed mkuemmel closed 2 years ago

mkuemmel commented 2 years ago

Move to a 1-based index for the ASSOC table as decided in #479

marcschefer commented 2 years ago

@mkuemmel it seems your changes are missing from this PR, I see they were pushed to develop then reverted...

mkuemmel commented 2 years ago

Sorry, I think I mixed up some things. In principle the main line is still in that branch: https://github.com/astrorama/SourceXtractorPlusPlus/blob/bf218f9aac9f8f9ccd5f5d73fa5d69d64432d444/SEImplementation/src/lib/Plugin/AssocMode/AssocModeConfig.cpp#L74

But there is a conflict. Should I try to resolve it?

marcschefer commented 2 years ago

I guess, but I'm a bit confused as I don't see the rest of the changes

mkuemmel commented 2 years ago

I can see. Let me look over this this evening. I'll also try to solve the conflict.

Apologies for the mess.

marcschefer commented 2 years ago

No worries, it's not urgent

mkuemmel commented 2 years ago

Okay, fine from my side!