search

astrosat / astrosat-ui

MIT License
0 stars 0 forks source link

Text field #102

Closed Reignable closed 4 years ago

Reignable commented 4 years ago

This PR closes #101

Made the text field which is an amalgamation of lots of other components. This is a copy paste of the actual Material UI TextField with some small changes. This also meant changing the input styling and removing the TextArea component so they could work better as part of the TextField. I also removed some components which were just being wrapped but without styling or markup changes.

RoryMacGregor88 commented 4 years ago

Only things I would say are that the label for the valid doesn't turn green, whereas the error label turns red.

And the label inside the input is flush against the side, don't know if it's in need of a bit of margin, but that also pushes the top one forward, which is maybe why it was left as is.

Reignable commented 4 years ago

I have reasoning for both of these.

Green label was because the green on white doesn't have good contrast to be readable. Although I just checked both colors and they both fail so really we shouldn't color either.

The reason for no space inside the input was due to designs, in some the text lines up with the underline but I just went and looked at the form controls designs and they don't, they do have space.

I'll change both of these, Will remove the error label being colored and add padding to the input.

Reignable commented 3 years ago

:tada: This PR is included in version 2.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: