search

astrosat / astrosat-ui

MIT License
0 stars 0 forks source link

create generic characters counter in the astrosat-ui library #153

Closed Slav666 closed 2 years ago

Slav666 commented 2 years ago

I added a new feature to the textField component in the Astrosat-Ui. We can pass the maxLength property with a number value to the textField component. It will activate the limit characters counter, which disables typing process when the counter reaches the 0 value. When the counter value is 0, the helperText font is in red. The 'Characters max length' text is hardcoded.

IssueID ORB-1225

This PR closes #

marksmall commented 2 years ago

I've no problem with multiple commits to get to the right code, but the commit messages have to get better, these are not good enough. To me it shows exasperation with being asked to make changes rather that reflecting on the changes being asked for and understanding what is being asked.

company-jenkins-ci commented 2 years ago

:tada: This PR is included in version 2.9.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: