search

astrosat / astrosat-ui

MIT License
0 stars 0 forks source link

feat(frontend): implement a maxLengthHelperText property in the textField #155

Closed Slav666 closed 2 years ago

Slav666 commented 2 years ago

I added a mechanism that allows providing two independent Helper text props.

IssueID ORB-1225

This PR closes #

marksmall commented 2 years ago

@Slav666 I think @RoryMacGregor88 and I have contradicted each other, we have since chatted and agreed what I put above is what should do. So to re-iterate:

  1. If user supplies maxLength prop only, then the default max length template is used e.g. ${charCount}/${maxLength} chars max length.
  2. If the user supplies maxLengthTemplate but no maxLength, then a console.warning should be displayed, stating that maxLengthTemplate must also have a maxLength prop.
  3. If the user supplies a maxLength and a maxLengthTemplate, the maxLengthTemplate should be checked for ${charCount} and ${maxLength} text in the template and a console.warning displayed if either doesn't exist. If both do exist, then the maxLengthTemplate should be used, instead of the default max length template.

Hope that is clear, if not, just ask in Slack and we can go through it further.

company-jenkins-ci commented 2 years ago

:tada: This PR is included in version 2.10.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: