astrosat / astrosat-ui

MIT License
0 stars 0 forks source link

fix the button component for a new version of Astrosat-ui #159

Closed Slav666 closed 2 years ago

Slav666 commented 2 years ago

I replaced the root CSS class with & character - that fixed the problem with the proper button size when we want to see it in a browser for the first time (we don't need to refresh the page to fix it). I moved the CSS rules (containedSizeLarge, textSizeLarge, outlinedSizeLarge) to the core.js file to fix the large button size for the button size story (I had an issue where a large button has the same size as a small size button). I added some other small CSS changes to fix all issues with the disabled button. The group button component is broken, but my changes to the button component didn't affect to make this broken.

IssueID: 1137

This PR closes #

marksmall commented 2 years ago

Some, non-code issues I saw, while looking at storybook:

Slav666 commented 2 years ago

Edge property - If given, uses a negative margin to counteract the padding on one side (this is often helpful for aligning the left or right side of the icon)

marksmall commented 2 years ago

@Slav666 Out of interest, who made the statement about negative margins? Please provide references to quotes, it could be from some 14 year old who doesn't know what they are talking about, but if we have references, we can see if we agree or not. Right now, I can't tell, you could be making it up.... I think it might come from material docs, but how am I supposed to know?

marksmall commented 2 years ago

@Slav666 In the storybook for Button -> Playground switching some of the options breaks storybook, I noticed this when setting color to default. I don't think default exists in mui 5, but check the docs for v4 and v5, if there are new options, use them, if it is just a case that default has been removed, then just remove it from the story.

Slav666 commented 2 years ago

Statement about edge is from the materaial-ui documentation: https://mui.com/material-ui/api/icon-button/#:~:text=edge,size%20and%20shape).

Slav666 commented 2 years ago

There is the proof that default colour value doesn't exist in the new version of material-ui: https://mui.com/material-ui/api/button/#:~:text=color,palette%20customization%20guide.

company-jenkins-ci commented 2 years ago

:tada: This PR is included in version 2.11.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

company-jenkins-ci commented 2 years ago

:tada: This PR is included in version 2.11.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

company-jenkins-ci commented 2 years ago

:tada: This PR is included in version 3.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: