search

astrosat / django-astrosat-users

Common backend library for Astrosat projects' user management
GNU General Public License v3.0
2 stars 0 forks source link

the variables used in app_settings should use the same names as their 3rd-party app equivalent #2

Open allynt opened 5 years ago

allynt commented 5 years ago

Currently, "astrosat_users/conf/app_settings" has code like this:


ASTROSAT_USERS_NOTIFY_SIGNUPS = getattr(
    settings, "ASTROSAT_USERS_NOTIFY_SIGNUPS",
    DynamicSetting(
        "astrosat_users.UserSettings.notify_signups",
        env("DJANGO_ASTROSAT_USERS_NOTIFY_SIGNUPS", default=False)
    )
)

And a lot of indirection is required to make sure that django-allauth uses these values rather than its default values.

However, if I just change the setting keys to use the same names as django-allauth (so "ACCOUNT_NOTIFY_USERS" instead of "ASTROSAT_USERS_NOTIFY_SIGNUPS") then it might just work.