[ ] Have you linked each commit to their issue e.g. First line should contain text like IssueID #123 - Update dependencies for front-end:. The important bit is the start IssueID #123, this will create a reference in the issue, to the commit.
[ ] Have you set Reviewers, labels and Milestone?
Is your feature request related to a problem? Please describe
This isn't actually a problem. I suspect that the code will be cleaner if I were to consolidate the three separate CustomerUser views and two separate Customer views into single views or viewset.
However I'm not sure this is possible for 2 reasons:
the complexity of the CustomerUser URL (it has 2 lookup args)
the confusion in merging genericCreateAPIView & genericUpdateAPIView
It needs more thought.
Describe the solution you'd like
Maybe have the first lookup_arg specified in the URL route itself:
Checklist
IssueID #123 - Update dependencies for front-end:
. The important bit is the startIssueID #123
, this will create a reference in the issue, to the commit.Is your feature request related to a problem? Please describe
This isn't actually a problem. I suspect that the code will be cleaner if I were to consolidate the three separate
CustomerUser
views and two separateCustomer
views into single views or viewset.However I'm not sure this is possible for 2 reasons:
CustomerUser
URL (it has 2 lookup args)genericCreateAPIView
&genericUpdateAPIView
It needs more thought.
Describe the solution you'd like
Maybe have the first lookup_arg specified in the URL route itself:
and have the second specified in the viewset attributes:
I would still have to overwrite
get_queryset
andget_object
.Also add an extra
@action
for invitations.