astrosat / django-astrosat-users

Common backend library for Astrosat projects' user management
GNU General Public License v3.0
2 stars 0 forks source link

Add fields to Customer #88

Closed allynt closed 4 years ago

allynt commented 4 years ago

Checklist

Is your feature request related to a problem? Please describe

There are several new fields that need to be added to the Customer model, as described in https://github.com/astrosat/orbis/issues/818

Describe the solution you'd like

add/update the following fields:

remove the following fields:

Don't forget to consider the admin/serializers/templates/views/tests as well as the model.

And remember that b/c this is a generic app we don't need to worry about orbs or licences - that will be added in the orbis project.

marksmall commented 4 years ago

@allynt Got some questions about the fields to change:

name

currently: name = models.SlugField(unique=True, blank=False, null=False), I'm changing to name = models.CharField(unique=True, blank=False, null=False)

official_name

currently: doesn't exist, I will add official_name = models.CharField(unique=True, blank=True, null=True), note the null option

company_type

currently: doesn't exist, I will add company_type = models.CharField(blank=True, choices=<whatever...>), should there be a max_length and any other params? Do we have a list of choices to create/plugin?

registered_number

currently: doesn't exist. You state this should be a CharField, if a number, why not an IntegerField? or is it an alpha-numeric value?

allynt commented 4 years ago