Unequal card header thicknesses in Contacts page

astrosonic / forge

Forensics Oriented Reporting Group Under Encryption

GNU General Public License v3.0

0 stars 7 forks source link

Unequal card header thicknesses in Contacts page #20

Closed gridhead closed 4 years ago

gridhead commented 4 years ago

OCD guy right here but even you'd feel unsettled when two identical looking card layouts are displayed one after the other but one of their header is thicker than another.

Reason

The presence of the search bar makes the bar go slightly thicker
Thickness is an issue because it makes the text of card header look top-aligned

The files can be found in the modern-layout branch of this repository. Specifically look for contocts.html file inside the templates folder which has the issue.

Screenshot from 2020-06-18 00-00-56

Ank-22 commented 4 years ago

I will pick up this up and try

arindampal-0 commented 4 years ago

I would like to fix this...

gridhead commented 4 years ago

Cool, @Ank221199 and @ArindamPal-0 you both can fork the project and start adding your respective changes in a new branch. When the changes are complete, make a PR and assign either me for review. If the changes made are satisfactory we will merge it to master or revert back to you with more suggested changes.

Good luck. This issue has been assigned to both of you.

P.S. Please avoid merging without consent and in case of any conflict during the merge, please let know before rebasing.

gridhead commented 4 years ago

Fixed in the latest commit 5c719d6.