search

astrosonic / wisdom-cli

A convenient command-line bound implementation to use Wikipedia
GNU General Public License v3.0
1 stars 5 forks source link

Package the main application into an executable binary #4

Open gridhead opened 3 years ago

gridhead commented 3 years ago

Make sure that you use PyInstaller and that it is compliant to Python 3.8 and above.

gridhead commented 3 years ago

Would you be willing to pick this up, @khallnayak?

Sameer-Mann commented 3 years ago

@t0xic0der i would like to help with this. Though it my first time. I am reading the documentation of pyinstaller.

Sameer-Mann commented 3 years ago

@t0xic0der i tried to make an executable for the app but it requires me sign the code manually on mac https://github.com/pyinstaller/pyinstaller/issues/4934 and even if i did that the binary file would not be distributable.

So i think using pyinstaller to distribute a mac os package is not feasible correct me if i am wrong.

gridhead commented 3 years ago

Sure, @Sameer-Mann. I am assigning this issue to you.

Feel free to take your time and learn about PyInstaller.

gridhead commented 3 years ago

Yes. The issue seems to be troubling especially macOS users. Could you try making an executable on a GNU/Linux system?

Sameer-Mann commented 3 years ago

ok I will try to make it work for gnu/linux systems

Sameer-Mann commented 3 years ago

@t0xic0der i made the package but it gives this when i try to run it. Screenshot 2020-11-04 at 2 35 35 PM After i export those two variables it works fine though. The encoding which the script is using and which it should use are not the same. Could u tell me how to add encoding based on the environment. I tried reading https://click.palletsprojects.com/python3/ but could not figure out how to do it.

gridhead commented 3 years ago

The code environment for the project is UTF-8 compliant only and does not support ASCII, unless added a exporting variable.

But then again, the export is restricted to your programming environment only and should not affect the repository.

Further reading : https://click.palletsprojects.com/en/7.x/python3/#python-3-surrogate-handling

Sameer-Mann commented 3 years ago

okay so now what should i do?