search

astroturfcss / astroturf

Better Styling through Compiling: CSS-in-JS for those that want it all.
https://astroturfcss.github.io/astroturf/
MIT License
2.28k stars 60 forks source link

Remove `postcss-strip-inline-comments` #733

Closed ai closed 2 years ago

ai commented 2 years ago

postcss-strip-inline-comments has no maintaince and use very old PostCSS 5.x with security vulnerability.

Seems like we are using this plugin in rare case of CLI. What do you think if we will remove it?

@jquense I can send PR together with #732

ai commented 2 years ago

The problem is also related with postcss-atroot

jquense commented 2 years ago

is there no other alternative to this one? It's not a rare edge case for me, I make use of it all the time.

ai commented 2 years ago

I think we can write a custom plugin since it is very simple 2 lines code https://github.com/mummybot/postcss-strip-inline-comments/blob/master/lib/strip-inline-comments.es6#L5-L7

postcss-atroot is more complicated. But seems like they released new version on top of PostCSS 8.

jquense commented 2 years ago

unlike the comment stripping, postcss-atroot is necessary for a number of styling flows so harder in that sense as well. Happy to replace the comment stripping if it's an easy plugin to write

ai commented 2 years ago

I didn’t find in postcss-atroot (seems like it was removed in 1.0).

Here is a fix for postcss-strip-inline-comments and chalk https://github.com/4Catalyzer/astroturf/pull/735