astroufsc / chimera

Chimera - Observatory Automation System
http://chimera.sf.net/
GNU General Public License v2.0
36 stars 19 forks source link

[PROPOSAL] New instrument for calibration lamps #83

Closed wschoenell closed 8 years ago

wschoenell commented 9 years ago

This proposal is divided in two parts:

1 - Create a new instrument for calibration lamps (i.e. flat field lamps, spectroscopic calibration lamps).

def turnOn(self, intensity=100.0):
    #Intensity goes from 1 percent to 100 percent of the capacity, in float numbers.
    return True if successful, otherwise False

def turnOff(self):
    return True if successful, otherwise False

def getState(self):
    return True or intensity if On, otherwise False
calibrationlamp:
   name: flat         # (or flat_Hg, flat_Na)
   type: LNADomeFlat  # (or ArduinoFlat, or WebSocketFlat, ...)
   dome_az: 0         # Azimuth of the dome when taking a calibration image (flat field)
   telescope_alt: 90  # Altitude of the telescope when taking a calibration image
   telescope_az: 45   # Azimuth of the telescope when taking a calibration image

If alt, az of dome/telescope are None, there is no need to move the telescope when exposing a calibration frame.

2 - Move the flat field lamp control from the dome to the new instrument. The expected behavior is that when we ask to a calibration frame on a calibration lamp which haves the alt/az properties set, chimera-cam must wait for both dome and telescope be on the right position before acquiring a frame.

ankanaan commented 9 years ago

I like it Bill.

On Tue, Jul 21, 2015 at 5:06 PM, William Schoenell <notifications@github.com

wrote:

This proposal is divided in two parts:

1 - Create a new instrument for calibration lamps (i.e. flat field lamps, spectroscopic calibration lamps).

  • Implementation suggestion:

def turnOn(self, intensity=100.0):

Intensity goes from 1 percent to 100 percent of the capacity, in float numbers.

return True if successful, otherwise False

def turnOff(self): return True if successful, otherwise False def getState(self) return True or intensity if On, otherwise False

  • Configuration suggestion:

calibrationlamp: name: flat # (or flat_Hg, flat_Na) type: LNADomeFlat # (or ArduinoFlat, or WebSocketFlat, ...) dome_az: 0 # Azimuth of the dome when taking a calibration image (flat field) telescope_alt: 90 # Altitude of the telescope when taking a calibration image telescope_az: 45 # Azimuth of the telescope when taking a calibration image

If alt, az of dome/telescope are None, there is no need to move the telescope when exposing a calibration frame.

2 - Move the flat field lamp control from the dome to the new instrument. The expected behavior is that when we ask to a calibration frame on a calibration lamp which haves the alt/az properties set, chimera-cam must wait for both dome and telescope be on the right position before acquiring a frame.

— Reply to this email directly or view it on GitHub https://github.com/astroufsc/chimera/issues/83.

wschoenell commented 8 years ago

Done on #130, #131 and #141