search

astroufsc / chimera

Chimera - Observatory Automation System
http://chimera.sf.net/
GNU General Public License v2.0
36 stars 19 forks source link

Add the ability to include camera rotation to the image WCS. #89

Closed tribeiro closed 9 years ago

tribeiro commented 9 years ago

Definition of the rotation matrix is found here: http://www.astro.iag.usp.br/~moser/notes/GAi_FITSimgs.html.

phsilva commented 9 years ago

Might be worth adding this link into the code as a comment, probably useful for future references.

tribeiro commented 9 years ago

Done...

wschoenell commented 9 years ago

Since we are adding more complexity to the WCS and we already had some bugs by doing it "by hand" the keywords to the fits header, why don't we add an property wcs to the Image object which is an WCS object from astropy, then, inside the getMetadata(), we just append to the headers the content of the image.wcs.to_header()?

Something like this: http://astropy.readthedocs.org/en/latest/wcs/#building-a-wcs-structure-programmatically

tribeiro commented 9 years ago

Can We accept this change now and discuss this in a different thread?

Em quinta-feira, 23 de julho de 2015, William Schoenell < notifications@github.com> escreveu:

Since we are adding more complexity to the WCS and we already had some bugs by doing it "by hand" the keywords to the fits header, why don't we add an property wcs to the Image object which is an WCS object from astropy, then, inside the getMetadata(), we just append to the headers the content of the image.wcs.to_header()?

Something like this:

http://astropy.readthedocs.org/en/latest/wcs/#building-a-wcs-structure-programmatically

— Reply to this email directly or view it on GitHub https://github.com/astroufsc/chimera/pull/89#issuecomment-124285928.

Sent from Mobile

wschoenell commented 9 years ago

Okay. I have tested this and it is working. I also ran wcslint tool and it works. I think that we can accept this PR for now, but if there are more parameters to be added to the WCS calculations, the way to go is discussing them on #93.