search

astroufsc / chimera

Chimera - Observatory Automation System
http://chimera.sf.net/
GNU General Public License v2.0
36 stars 19 forks source link

[chimera-pverify] Review #99

Closed wschoenell closed 8 years ago

wschoenell commented 9 years ago

I am going thru pverify and fixing all the bugs that I find and make it usable again. This version is a working version for start. A LOT should be improved, but it at least works now.

The main changes are:

ankanaan commented 9 years ago

pverify is and always perfect :-)

On Fri, Jul 31, 2015 at 12:51 PM, William Schoenell < notifications@github.com> wrote:

I am going thru pverify and fixing all the bugs that I find and make it usable again. This version is a working version for start. A LOT should be improved, but it at least works now.

The main changes are:

-

Added a download method to ImageUtil for downloading remote images. This is useful when you have the camera running on another computer than the one where you are running the pverify;

Removed IRAF dependency;

A lot of code organization, removed not-used imports, changed print()s by log.debug()s etc on (and only) pverify methods.

You can view, comment on, or merge this pull request online at:

https://github.com/astroufsc/chimera/pull/99 Commit Summary

  • Added util to automatically download images from http server
  • Many bug fixes on chimera-pverify.

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/astroufsc/chimera/pull/99.

wschoenell commented 9 years ago

Added more changes:

ankanaan commented 9 years ago

On Mon, Aug 3, 2015 at 10:26 AM, William Schoenell <notifications@github.com

wrote:

Added more changes:

  • Change the filter to filter config directive file when exposing;
  • Documented pverify interface. Changed tolra and toldec config parameters from max_tolerance which is equals to sqrt(delta_ra2 + delta_dec2), max_trials is max_tries now for compatibility with the other interfaces;

not sure I like this. Telescopes often point better in one direction, in which case it makes sense to have different tolerances - at least for equatorial mounts.

  • Fixed an issue of determining files base name when remote client is windows and local is linux and vice-versa;
  • Added worldAtCenter() method to Image class;

— Reply to this email directly or view it on GitHub https://github.com/astroufsc/chimera/pull/99#issuecomment-127233150.

wschoenell commented 9 years ago

@ankanaan, Yes. I see your point. I just changed back to what it was on 5203d3b.

Thanks!

wschoenell commented 8 years ago

Merging this to afterwards move into a plugin