search

astruyk / Ares

An arma3 mod that adds some extra functionality to Zeus
51 stars 11 forks source link

Added modules for transfering groups to the server #216

Open sthorshaug opened 8 years ago

sthorshaug commented 8 years ago

One module transfers a single group. The other module transfers all groups. Relates to issue #159

astruyk commented 8 years ago

Looks pretty awesome. The only thing I would suggest is maybe using a single module and deciding which units to attempt to move to the server based on where the module was dropped. So, for example if the user drops the module in empty space assume they want all units moved but if they drop it on a unit assume they want that units group moved.

This keeps the number of modules lower (so less things to sort through each time you want to find a module you're interested in).

Also a couple of small code-style comments:

By convention the names for functions and global variables have capitals after the underscore (so Ares_ChangeOwnerToServerFunction or Ares_ChangeOwnerToServerCodeBlock instead of Ares_changeOwnerToServerFunction.

All the other code uses spaces between 'if' and opening parenthesis. For example,if (...) instead of if(...)

Lastly all the '{''s belong on their own lines (except in the case of foreach):

if (...)
{
<tab>// ...
}

is preferred over

if (...) {
<tab>// ...
}

https://github.com/astruyk/Ares/blob/master/src/addons/ares_zeusExtensions/scripts/Equipment_RemoveWeaponOptics.sqf has some examples of the various code blocks indentation.

sthorshaug commented 8 years ago

Thanks! I agree on your view on implementing it as a single module, and I'll fix the code style issues as well.

I'll look into it next week.

Delta-99 commented 8 years ago

Oh, looks like Astruyk is back in action maybe. You going to make updates to Ares? Most of us figured you abandoned Ares so people are asking if they can maintain it or take it over on your forum thread.

sthorshaug commented 8 years ago

FYI: There will be a little delay before I fix the scripts. My computer just had a bad trip, so I need to fix it first (replace som hardware).

sthorshaug commented 8 years ago

Sometimes when transfering units to the server, some units loose their gear and uniform. Other people are experiencing this as well (example here), so I guess it's a feature/bug.

nomisum commented 6 years ago

dont want to necro, but when transfering units to the server, some units loose their gear and uniform – can this be related to mod specific loadout randomization scripts? we have similar issues with our loadout system.