search

astuder / lightroom-map-fix

Fixing the Map module in Lightroom Classic
125 stars 17 forks source link

Possible URL change? #12

Open ndevenish opened 5 years ago

ndevenish commented 5 years ago

I found that I also needed to replace maps.google.com with maps.googleapis.com now. There's also a client=gme-adobesystems_TESTING_INVALID entry that I replaced with the key, but I don't know if that was required.

astuder commented 5 years ago

I just checked with my own LR installation I patched a few months ago with just the keys, and it still works.

What version of LR are you using? What functionality did not work before you patched the API URL? And in which file did you patch the API URL?

ndevenish commented 5 years ago

6.14, just reinstalled a couple of weeks ago after not using it for a while. I tried to use the maps for the first time and neither the main screen or side window were loading. Even after the initial patches they didn't load, until I changed the URL. Maybe it was something unrelated, or maybe if it contacted the servers before it had some sort of session key pre-registered?

astuder commented 5 years ago

Thank you for the feedback. I will leave this issue open for now. Anyone reading this and encountering the same issue, please let me know.

jeremybickerstaffe commented 5 years ago

I have a Mac with LR 6.14. I've run the patching steps without success and am wondering whether I might need this different URL too. However I can't see where I need to make the change. Please can you let me know? Thanks.

wagnerralf commented 5 years ago

Thank you for the feedback. I will leave this issue open for now. Anyone reading this and encountering the same issue, please let me know.

Hi, just patch 6.14 LR on Win10 and did not work. maybe I have to change URL, too ? But unclear where to change... Thanks

wagnerralf commented 5 years ago

6.14, just reinstalled a couple of weeks ago after not using it for a while. I tried to use the maps for the first time and neither the main screen or side window were loading. Even after the initial patches they didn't load, until I changed the URL. Maybe it was something unrelated, or maybe if it contacted the servers before it had some sort of session key pre-registered?

where did you change the URL ?

astuder commented 5 years ago

I still can't reproduce the URL issue and think this is a red herring. The posts by John from Portland on DPreview may give you some ideas what went wrong: https://www.dpreview.com/forums/post/62531780

wagnerralf commented 5 years ago

This was just an idea, as maps are not shown in Lightroom 6.14 (google maps could not be loaded--check javascript console).

 

I patched like this

 

patchluastr.exe LOCATIONMAPVIEW.LUA "client=gme-adobesystems" "key=xxx" -o LOCATIONMAPVIEW.bin patchluastr.exe AGREVERSEGEOCODESERVICE.LUA "client=gme-adobesystems" "key=xxx" -o AGREVERSEGEOCODESERVICE.bin patchluastr.exe LOCATIONDEBUGPANEL.LUA "nature" "street" -o LOCATIONDEBUGPANEL.bin

 

and updated location.lrmodule as described.

 

 

chosen APIs:

Maps JavaScript API
Geocoding API

 

If I check stats, seems Maps JavaScript API was never requested so far

 

But maybe it's a different issue as URL

 

Regards

-- Ralf Wagner

   

Gesendet: Montag, 22. April 2019 um 17:10 Uhr Von: "Adrian Studer" notifications@github.com An: astuder/lightroom-map-fix lightroom-map-fix@noreply.github.com Cc: wagnerralf wagnerr@web.de, Comment comment@noreply.github.com Betreff: Re: [astuder/lightroom-map-fix] Possible URL change? (#12)

I still can't reproduce the URL issue and think this is a red herring. The posts by John from Portland on DPreview may give you some ideas what went wrong: https://www.dpreview.com/forums/post/62531780

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

Malte-Neu commented 5 years ago

I had the same Problem, that the replacements from the readme doesn't work for me. I had to apply the replacements from the first post, now it works.

I use LR 6.14 on windows 7 in german.

The location from the location.lrmodule is diffrent from the readme at "C:\Program Files\Adobe\Adobe Lightroom\Location.lrmodule"

If its helful for you, I can send you copy from my lrmodule file.

wagnerralf commented 5 years ago

Hello,I use the same location but would be helpful to compare with your file if you don`t mind..RegardsRalf

[removed quoted email content to hide private information]

Malte-Neu commented 5 years ago

These are the patch commands I used to get it working:

patchluastr.exe LOCATIONMAPVIEW.LUA "client=gme-adobesystems_TESTING_INVALID" "key=<my key>" -o LOCATIONMAPVIEW.tmp
patchluastr.exe LOCATIONMAPVIEW.tmp "maps.google.com" "maps.googleapis.com" -o LOCATIONMAPVIEW.bin

patchluastr.exe AGREVERSEGEOCODESERVICE.LUA "client=gme-adobesystems" "key=<my key>" -o AGREVERSEGEOCODESERVICE.bin

patchluastr.exe LOCATIONDEBUGPANEL.LUA "nature" "street" -o LOCATIONDEBUGPANEL.bin
wagnerralf commented 5 years ago

same issue. did not work error

Malte-Neu commented 5 years ago

Hallo Ralf,

ich kann Dir anbieten, dass Du mir deine originale location.lrmodule -Datei schickst und sich sie mir mal ansehe.

Viele Grüße Malte

[removed quoted email content to hide private information]

wagnerralf commented 5 years ago

Hallo Malte,

 

jab folgendes gemacht

patchluastr.exe LOCATIONMAPVIEW.LUA "client=gme-adobesystems_TESTING_INVALID" "key=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx" -o LOCATIONMAPVIEW.1 patchluastr.exe LOCATIONMAPVIEW.1 "client=gme-adobesystems" "key=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx" -o LOCATIONMAPVIEW.2 patchluastr.exe LOCATIONMAPVIEW.2 "maps.google.com" "maps.googleapis.com" -o LOCATIONMAPVIEW.bin

patchluastr.exe AGREVERSEGEOCODESERVICE.LUA "client=gme-adobesystems" "key=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx" -o AGREVERSEGEOCODESERVICE.bin patchluastr.exe LOCATIONDEBUGPANEL.LUA "nature" "street" -o LOCATIONDEBUGPANEL.bin

 

xxxx war mein key, hate es mit Key= als auch mit key=xxxxxx

 

probiert.

 

File im Anhang

-- Ralf Wagner [removed quoted email content to hide private information]

capelevy commented 5 years ago

Hi,

And thank you for all the great research everyone!

I replaced the "gme-adobesystems_TESTING_INVALID" and "gme-adobesystems" strings with may API keys, and everyting everything seems to be working. I did not have to replace the maps.google.com part.

Again, well done to everyone figuring this out :)

CPL

timbothegreat3 commented 5 years ago

I have followed the instructions above and all seems to be working with a few observations.

1) Geocoding is very slow, api seems to get many errors. 2) I get a message "map error: to many requests" 3) the large main map is watermarked in tiles with "for development purposes only"

But I really do apreciate the effort put it to this. really annoyed me losing this feature.

astuder commented 5 years ago

@timbothegreat3 I don't see the watermark or map errors. I'd check on the Google Cloud Console whether there are more details about the error.

Maybe you have too many geo-tagged images on that map. For me, it's usually only a few hundreds at a time.

timbothegreat3 commented 5 years ago

With some more playing all issues solved. Google Maps developer platform wasn't enabled also an old billing C/C.

kassi commented 4 years ago

@timbothegreat3 How did you do that? I completely stumble with the Google Cloud website. Had to klcik 100 times to get everything connected with a billing account to a project and an API key (where I needed to make my project public for externals since I'm not G Suite user) and what not. Now a request with the key to an https geocoder url is working in the terminal, but LR still gives me the same error: still getting the "Hoppla" screen. I think I changed everything correctly in the files, but who knows. Is there a way to enable JavaScript console for the lightroom plugin (as the error message suggests)?

BTW: I also replaced the maps.google.com with maps.googleapis.com now. I see a correct map at startup, but then LR immediately show the "Hoppla" page.