search

astuder / lightroom-map-fix

Fixing the Map module in Lightroom Classic
125 stars 17 forks source link

Works with Lightroom 6.14 on a Mac as well! #2

Closed pmarciniak closed 5 years ago

pmarciniak commented 5 years ago

Hi,

Just wanted to report that I've successfully applied your method to Lightroom 6.14 on a Mac. The process is even easier here as the lua files to modify are available directly from the filesystem (so the Resource Hacker steps may be skipped). The files to modify are:

Note that I don't have python 3 installed on my Mac, so I made the modifications by hand, using vim. One just needs to remember to also update the encoded lua string size when replacing client=... with key=... .

evanwarner commented 5 years ago

(Deleted my first question, the lower portion of the code is the raw source I can read fine.)

Can you explain what you mean by updating the encoded lua string size?

Thank you!!!

pmarciniak commented 5 years ago

Evan, just follow what the script does. And if you're unsure, I recommend just running the script and letting it do the heavy lifting for you.

astuder commented 5 years ago

Thanks @pmarciniak for sharing!

@evanwarner in compiled LUA code, string constants are stored as: Type: 4 for type string Length: 4 or 8 bytes, depending on LUA size_t defined in file header String: zero terminated string

My Python script searches for the strings to replace, modifies them and updates the length.

evanwarner commented 5 years ago

Done! The manual string length encoding didn't quite make sense to me still so I installed Python3 and ran the script on the two files. Maps module is working fine Thanks to both of you!

rcsahli commented 5 years ago

Hi, This is to let you know that it worked for Lightroom 6.14 under Win7 64 enterprise. Thank you very much for your work. Best Regards

stefanhelm commented 5 years ago

Thanks a lot for this great tool!! Works like a charm :-) Patched my Lightroom 6.14 on Mac High Sierra. First of all I installed python 3 (it's a very fast process). Than I located both lua files at the place pmarciniak mentioned in his message above. I patched them with your python script and my google api key. Now the Lightroom Map Module works fine again.

astuder commented 5 years ago

Thanks all for your feedback!

I added instructions for Mac to the README. Let me know if there are any errors or need for more clarity.

evanwarner commented 5 years ago

One clarification you could add for Mac: in order to view the files inside Lightroom.app and Location.agmodule, people will need to right-click on them and select Show Package Contents.

astuder commented 5 years ago

Thanks! I tried to clarify. You can also directly suggest an edit by clicking on the pencil icon in the top-right of the text box.