astuder / lightroom-map-fix

Fixing the Map module in Lightroom Classic
125 stars 17 forks source link

?:0) attempt to index a boolean value #20

Closed keithdw1973 closed 5 years ago

keithdw1973 commented 5 years ago

I am a complete noob to this, so followed the instructions to the letter (I think).

I extracted the three .LUA files from the Location.lrmodule file and using the patchluastr.exe file in Windows 10, had the following positive messages (I've replaced most of my API Key with ????.

\Lightroom Map Fix>patchluastr.exe LOCATIONMAPVIEW.LUA "client=gme-adobesystems" "key=AI???????????????????????????????p_wes" -o LOCATIONMAPVIEW.bin
Processing LOCATIONMAPVIEW.LUA
Lua 5.1 detected
Lua settings: endian 1, int 4, size_t 8, instruction 4, number 4
119454 bytes read from file
Found 'client=gme-adobesystems' at 10424
Found 'client=gme-adobesystems' at 21086
Updated 2 strings
119494 bytes written to LOCATIONMAPVIEW.bin

\Lightroom Map Fix>patchluastr.exe AGREVERSEGEOCODESERVICE.LUA "client=gme-adobesystems" "key=AI???????????????????????????????p_wes" -o AGREVERSEGEOCODESERVICE.bin
Processing AGREVERSEGEOCODESERVICE.LUA
Lua 5.1 detected
Lua settings: endian 1, int 4, size_t 8, instruction 4, number 4
10715 bytes read from file
Found 'client=gme-adobesystems' at 1601
Updated 1 strings
10735 bytes written to AGREVERSEGEOCODESERVICE.bin

\Lightroom Map Fix>patchluastr.exe LOCATIONDEBUGPANEL.LUA "nature" "street" -o LOCATIONDEBUGPANEL.bin
Processing LOCATIONDEBUGPANEL.LUA
Lua 5.1 detected
Lua settings: endian 1, int 4, size_t 8, instruction 4, number 4
11590 bytes read from file
Found 'nature' at 11464
Updated 1 strings
11590 bytes written to LOCATIONDEBUGPANEL.bin

I then re-inserted the .bin files into the Location.lrmodule file (original size 1232KB, patched 921KB).

This was then copied back into the Lightroom install folder - so far so good!

Lightroom loaded correctly, but when I click on the map tab on the menu I get an error message ?:0) attempt to index a boolean value image

I am running Lightroom CC 2015.14 Release - I'm not sure what version number that is! image

Thanks for your efforts, I hope this is something I'm doing wrong, missing.

astuder commented 5 years ago

I don't have Lightroom CC, so I don't know if this patch also works for that version.

Does your API key contain special characters? Mine only contains letters and numbers.

keithdw1973 commented 5 years ago

My API key does contain an underscore, yes! image

I used the copy feature when generating the key to ensure no typos! image

On my dashboard, it seems to show things are getting through, but why there are 90% error and not 100% I have no idea. image

Anyway, I think I have an old copy of LM6 somewhere in my archive, I've dig it out and try with that.

astuder commented 5 years ago

Underscore shouldn't be an issue. I was more worried about & and ?, which would require some HTTP escaping. But as the requests show up in your console, the patching of the API key is very likely working.

I'm not very familiar with the Google cloud, but if it's possible to drill down into the errors or find a log we may have more clues on what goes wrong.

astuder commented 5 years ago

PS: If you send me the unpatched .LUA files to the email address on my GitHub profile I can verify that the patching works as expected.

keithdw1973 commented 5 years ago

Sure thing astuder, I will send you the .lua files.

I found out that the installer from Adobe for Lightroom 6 and CC 2015 are the same, and only change branding upon registration with Adobe!

The brand new Lightroom free trial download always starts off as Lightroom CC, but after installation it can be converted to Lightroom 6 if that’s what you decide to buy instead… After you make the standalone purchase, the product branding will transform to Lightroom 6

https://prodesigntools.com/differences-between-lightroom-6-cc-vs-5.html

I think, also there may be a problem with my Google API account, which Google are investigating. It seems the billing is not setup correctly, although all the details are correct! So it is only allowing 1 API hit per day. So, I'll wait to see what they say about that.

keithdw1973 commented 5 years ago

Had a response from Google and they fixed my console.cloud.google.com account. Everything seems to be working as expected now. So the issue was on googles side.

Thanks for your efforts, and thanks for the Lightroom fix.