search

astuder / lightroom-map-fix

Fixing the Map module in Lightroom Classic
125 stars 17 forks source link

Lightroom 6.14 : Map not working #21

Closed sebsebseb1982 closed 4 years ago

sebsebseb1982 commented 5 years ago

Hi !

I've modified my Location.lrmodule as explained here, but it is still not working :-(

files lightroomError patchLUA

Do you know where I can find logs that could help me ?

Thank you, Sébastien

astuder commented 5 years ago

Hi Sebastien,

I don't know if Lightroom writes any logs. You should see traffic in your Google Cloud account. If there is no activity on then most likely the API key is wrong.

Also make sure to enable the necessary APIs on your Google Cloud account as described in section 2.

Best Regards, Adrian

sebsebseb1982 commented 5 years ago

Hi, thank you for your answer ! I don't see any traffic in my Google Cloud Account.

Can you confirm me that the key to use is this one :

key

I've got theses API activated :

apis

If you can confirm that everything seems OK, I'll will try to regenerate my key and patch again the module.

astuder commented 5 years ago

Yes, that's the key. Double check that you included the API key without extra characters (for example don't add the { } brackets).

APIs look ok.

Make sure to exit Lightroom before updating the files. To be sure that you update the correct location, you can rename the file and see if Lightroom complains. If it doesn't you may be modifying the wrong file.

sebsebseb1982 commented 5 years ago

I've regenerate my key which now does nto contains hyphen (the first one was). Still not working. My key contains only alphanumerical chars now. Lightroom was closed during process. I've tried to rename Location.lrmodule --> Location.lrmodule.bak. Map module is still bugged and this is the same error (it does not ask for Location.lrmodule.bak explicitly). I'm modifying C:\Program Files\Adobe\Adobe Lightroom\Location.lrmodule

sebsebseb1982 commented 5 years ago

I've checked hexa content and replacement seems to be done :-\

astuder commented 5 years ago

I just checked, and I get the error you see when I rename my Location.lrmodule.

When you replace your module with the original (I hope you have a backup), what error do you get?

sebsebseb1982 commented 5 years ago

With original or without any Location.lrmodule, I've got the same error as the one in my first comment. I' ve not find any log or debug mode/console ... Could I sent you my modified module ?

timbothegreat3 commented 5 years ago

I had heaps of trouble getting this working. My top is that modifying the file is pretty straight forward with clear instructions. I missed some of the things in the google end of things which made mine work straight away after fixing,

On Wed, 28 Aug 2019 at 04:52, sebsebseb1982 notifications@github.com wrote:

With original or without any Location.lrmodule, I've got the same error as the one in my first comment. I' ve not find any log or debug mode/console ... Could I sent you my modified module ?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/astuder/lightroom-map-fix/issues/21?email_source=notifications&email_token=AB6VIVDHYHW6GEXWG2EBPX3QGVZWLA5CNFSM4IPOPHE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5IYGII#issuecomment-525435681, or mute the thread https://github.com/notifications/unsubscribe-auth/AB6VIVGQ7DVUUNW7AIG4PZ3QGVZWLANCNFSM4IPOPHEQ .

sebsebseb1982 commented 5 years ago

My Google API seems to be OK. I'll try to find someone who can test my module

Sventheviking commented 4 years ago

Hello, I performed all the steps, including changing the URL but unfortunately it still does not work. Using a very simple test page I was able to validate my api key so that's not the issue.

Is there a way to turn on the location debug panel or otherwise see which calls ligthroom makes ?

sebsebseb1982 commented 4 years ago

I've got exactly the same problem. If you find solution I'm interested !

astuder commented 4 years ago

Sorry, but I really can't reproduce those issues. Are any of you using non-english versions of LR?

Unfortunately, I haven't figured out how to enable the debug console that the error message mentions. I suspect it's a standard message from the embedded browser that displays the map.

sebsebseb1982 commented 4 years ago

Hi Astruder,

I don't know if it is a specific version, but mine is translated in french.

image

If you want, I can send you my Location.lrmodule to test (I will invalidate my API key later).

Sventheviking commented 4 years ago

I'm using it in French as well but doubt Adobe made language specific versions. Anyway I switched to English in Preferences and the error is still there.

Do you know how to trace all the http calls and responses ? I'll do some research on my side, just wondering if you alredy did it.

sebsebseb1982 commented 4 years ago

Nope. I haven't time to do it now but maybe Fiddler (if it's still compatible with Windows 10) could bring answers.

Sventheviking commented 4 years ago

Something really weird happened that I absolutely cannot explain...

I went back to resource hacker to check location.lrmodule and it definitely is the original... I have absolutely no clue which file LR is using but the fact is that it somehow switched to my API key. Maybe it cached data from the modified file somewhere and just decided to use it.

astuder commented 4 years ago

Someone just posted this on the thread in DPreview:

IMPORTANT NOTE: Windows 10, I had a lot of trouble and tried 3 times, despite having Google API experience. The problem was, I didn't remove the backup file from the original directory (and it still had the same .lrmodule extension). Even though it had an obviously different filename, it was still getting picked up by LR instead of my patched file. Either change the extension of the backup file, or move it. I hope this helps someone else!

Please let me know if this solves the mystery for any of you.

sebsebseb1982 commented 4 years ago

Yes ! that's it ! Thank you very much everybody !

Sventheviking commented 4 years ago

Same for me ! Changing the extension did it.

Thanks a lot.