astuff / astuff_sensor_msgs

A set of messages specific to each sensor supported by AutonomouStuff.
MIT License
48 stars 41 forks source link

Consider moving pacmod_msgs into the pacmod3 driver repo #59

Closed icolwell-as closed 2 years ago

icolwell-as commented 4 years ago

Much like all other ROS drivers, consider moving the message package into the same repo as the driver package.

JWhitleyWork commented 3 years ago

There's no real technical benefit or detrement to having them in different repos. It's just a "logical grouping" thing. However, for the other messages, I highly recommend leaving them here so they are open-source rather than adding them to the repos for the closed-source drivers. People do use them. For example, https://github.com/search?q=delphi_esr_msgs&type=code, https://github.com/search?q=derived_object_msgs&type=code, https://github.com/search?q=ibeo_msgs&type=code, etc.

icolwell-as commented 2 years ago

Starting with Ubuntu 20.04 (ROS1 Noetic and ROS2 Foxy), pacmod_msgs has turned into pacmod3_msgs and it is located in it's own repo: https://github.com/astuff/pacmod3_msgs