search

astuff / automotive_autonomy_msgs

A set of ROS messages for automation of mobile platforms.
MIT License
19 stars 10 forks source link

ROS1/ROS2 Hybrid Packages #15

Closed JWhitleyWork closed 5 years ago

JWhitleyWork commented 5 years ago

This PR migrates all message packages in this repo to ROS1/ROS2 hybrid packages. The only substantive change is PointOfInterestRequest.requestId to PointOfInterestRequest.request_id and the same for PointOfInterestResponse.requestId to PointOfInterestResponse.request_id. Migration rules were created to update these messages.

@Daniel-Stanek - Please let me know which (if any) packages need to be updated to accommodate this change.

Daniel-Stanek commented 5 years ago

Looks like the old at_ui has a couple of places. It's no longer used, but it's still in ros_hmi, and that's used. The ros_points_of_interest repo is so old it's probably not worth it.

Daniel Stanek

AutonomouStuff, LLC

T: 314-270-2123 | F: 309-481-5425

dstanek@autonomoustuff.commailto:jwhitley@autonomoustuff.com | www.AutonomouStuff.comhttp://www.AutonomouStuff.com/

Bringing Together the World's Best Technologies™

The preceding e-mail message (including any attachments) contains information that may be confidential, may be protected by the attorney-client or other applicable privileges, or may constitute non-public information. It is intended to be conveyed only to the designated recipient(s) named above. If you are not an intended recipient of this message, please notify the sender by replying to this message and then delete all copies of it from your computer system. Any use, dissemination, distribution, or reproduction of this message by unintended recipients is not authorized and may be unlawful.

From: Joshua Whitley notifications@github.com Sent: Tuesday, November 19, 2019 11:53 AM To: astuff/automotive_autonomy_msgs automotive_autonomy_msgs@noreply.github.com Cc: Daniel Stanek dstanek@autonomoustuff.com; Mention mention@noreply.github.com Subject: [astuff/automotive_autonomy_msgs] ROS1/ROS2 Hybrid Packages (#15)

This email comes from outside the organization.

This PR migrates all message packages in this repo to ROS1/ROS2 hybrid packages. The only substantive change is PointOfInterestRequest.requestId to PointOfInterestRequest.request_id and the same for PointOfInterestResponse.requestId to PointOfInterestResponse.request_id. Migration rules were created to update these messages.

@Daniel-Stanekhttps://github.com/Daniel-Stanek - Please let me know which (if any) packages need to be updated to accommodate this change.

You can view, comment on, or merge this pull request online at:

https://github.com/astuff/automotive_autonomy_msgs/pull/15

Commit Summary

File Changes

Patch Links:

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/astuff/automotive_autonomy_msgs/pull/15?email_source=notifications&email_token=AHOEIYDRG7ONNBLKBO72LD3QUQR3LA5CNFSM4JPHCWI2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H2NNQYQ, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHOEIYCCD754KHF3UTMBUQ3QUQR3LANCNFSM4JPHCWIQ.