astuff / avt_vimba_camera

ROS1/2 Driver for AVT cameras using VIMBA SDK.
Other
22 stars 43 forks source link

ROS2 avt_vimba_camera under Windows #106

Open mattberkem opened 2 years ago

mattberkem commented 2 years ago

ROS2 runs under Windows, as well as Linux. Also, vimba drivers are available for Windows. However, the current version of avt_vimba_camera doesn't seem to be well-adapted to Windows. For example, min() and max() are defined in windows.h and thus need to be distinguished from the desired versions. Also, diagnostic_updater is not included in the binary version of ROS2 for Windows but is needed for avt_vimba_camera. Is there anyone working on a version of avt_vimba_camera that would also run under Windows?

icolwell-as commented 2 years ago

Hi @mattberkem, the driver here was only built and tested on Ubuntu Linux. ROS2 technically supports Windows as a "Tier 1 OS", but most of the community-developed ROS1/2 software (this driver for example, also diagnostic_updater as you've noticed) is developed for Ubuntu. I'm happy to review any PRs that enable Windows support, but you are likely better off developing your system using Ubuntu if that is an option for you, since you may run into more issues in the future with limited Windows support.

I'll leave this open in case anyone has forked this driver and adapted it to Windows, and wishes to share.