search

astuff / ibeo_core

Core library for ROS drivers for Ibeo products
Other
5 stars 8 forks source link

compile under noetic #17

Open ace-at-git opened 1 year ago

ace-at-git commented 1 year ago

I wanted to work with ibeo_lux under ROS noetic and recognized that the code requires to be build at least with c++14.

In order to make this code build under noetic I changed the compile options in CMakeList.txt to: add_compile_options(-std=c++14)

I also needed in the ibeo_lux CMakeList.txt to change the compile options to: add_definitions(-std=c++14 -Wall -Wextra -DBUILD_ROS)

I will generate an issue also for ibeo_lux.

It would be nice if someone can take take of this to enable working under noetic. :-)

Regards

Bernd

icolwell-as commented 1 year ago

Hi @ace-at-git, thanks for sharing your findings! Feel free to open a PR if you like, this driver is no longer actively maintained, but small changes like the ones you mention are easy to review and merge.