astuff / kvaser_interface

A Kvaser CAN interface ROS abstraction layer.
MIT License
84 stars 52 forks source link

Memory Management Improvements and Clean-up #14

Closed JWhitleyWork closed 5 years ago

JWhitleyWork commented 5 years ago

This PR not only contains significant clean-up and linting but also improves memory management by using a smart pointer for handling the Kvaser handle. However, many of the linter changes require API-breaking changes such as moving the sourced location of the header file and changing method names to conform to ROS C++ standards. This will require some testing from @rgunjala93 (and/or others) to verify that no additional memory leaks or performance problems have been created. Rinda - please give us an update once this has been tested on at least a couple of devices for a few hours for stability.