search

astuff / kvaser_interface

A Kvaser CAN interface ROS abstraction layer.
MIT License
84 stars 52 forks source link

Adding canmonitor tool. #20

Closed JWhitleyWork closed 5 years ago

JWhitleyWork commented 5 years ago

Accidentally committed the list_channels tool to master... Realized it before adding canmonitor. After this, you can:

rosrun kvaser_interface canmonitor

It will automatically choose channel index 0 with bitrate 500000. -c and -b options change these.

JWhitleyWork commented 5 years ago

Don't approve yet: I forgot that I need to add a timestamp to the output and switch to using std::this_thread::sleep_for instead of usleep.

JWhitleyWork commented 5 years ago

@Daniel-Stanek / @zoakesAStuff - Everything is fixed now - except CI. CircleCI is having a partial outage. But it builds and all tests run, including lint. Please review for code style / bugs / etc. when you have time. Thanks.

JWhitleyWork commented 5 years ago

Nevermind - CI is working now.

JWhitleyWork commented 5 years ago

@zoakesAStuff - Testing was already completed with @rgunjala93. The above change should not be earth-shattering and is logically identical to tested code. Merging.