search

astuff / kvaser_interface

A Kvaser CAN interface ROS abstraction layer.
MIT License
84 stars 52 forks source link

Feat/callbacks #21

Closed JWhitleyWork closed 5 years ago

JWhitleyWork commented 5 years ago

Needs testing, for sure. Didn't want to do more development until this portion was reviewed by others (and it's a lot of changes already). This includes the following:

  1. Rename linuxcan.cpp to kvaser_interface.cpp and ros_linuxcan to ros_kvaser_interface.
  2. Creates a CanMsg object with all flags and error flags. Supports CAN FD (can_msgs does not yet).
  3. Passes a CanMsg for read and write operations.
  4. Adds the ability to register a callback function for reading.
  5. Changes kvaser_interface_node and canmonitor to use the callback functionality.
JWhitleyWork commented 5 years ago

Also, this is merging to a develop branch. release branch is now gone since master contains our releases as tags.

JWhitleyWork commented 5 years ago

This PR also addresses #22.

JWhitleyWork commented 5 years ago

@zoakesAStuff and @Daniel-Stanek - If you don't have any further comments, are you guys OK with approving?

zoakesAStuff commented 5 years ago

Haven't finished going back over it fully yet. I'll let you know.