astuff / kvaser_interface

A Kvaser CAN interface ROS abstraction layer.
MIT License
84 stars 52 forks source link

Empty (valid) messages not being published. #39

Closed JWhitleyWork closed 5 years ago

JWhitleyWork commented 5 years ago

Messages with DLC = 0 and no data in the payload (but no flags) were not being published. These messages are valid and were being passed by kvaser_interface up to ROS, then silently dropped. This is undesired behavior. The CAN bridge now passes these messages but drops CAN FD (not supported by can_msgs/Frame), TX ACK, TX RQ, Message Delay notifications, and TX NACK messages. These are informational-only messages and cannot be correctly represented by can_msgs/Frame anyway.