search

astuff / kvaser_interface

A Kvaser CAN interface ROS abstraction layer.
MIT License
83 stars 51 forks source link

Fix/rewrite cmake #57

Closed wep21 closed 3 years ago

wep21 commented 3 years ago
wep21 commented 3 years ago

@icolwell-as Could you review this?

icolwell-as commented 3 years ago

Thanks for the PR @wep21, I can test/review this once we start to move other packages towards ROS2. I am not sure about the future of the kvaser_interface package since we are trying to move towards socketCAN in the future. I'll let you know what gets decided.

icolwell-as commented 3 years ago

Hi @wep21, AutonomouStuff will be releasing the kvaser_interface package on ROS2 foxy and rolling, we will also do a Noetic release as well.

I've tested your PR today on ROS2 foxy, works great! thanks for submitting.